Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced NULL with nullptr #961

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

stephanie-eng
Copy link
Contributor

Description

Replace NULL with nullptr throughout the project as per #841

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #961 (7090f0a) into main (3092518) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   57.90%   57.90%   -0.00%     
==========================================
  Files         310      310              
  Lines       26113    26113              
==========================================
- Hits        15118    15117       -1     
- Misses      10995    10996       +1     
Impacted Files Coverage Δ
...include/moveit/collision_detection/collision_env.h 100.00% <ø> (ø)
.../moveit/collision_detection_fcl/collision_common.h 89.19% <ø> (ø)
...raint_samplers/src/default_constraint_samplers.cpp 72.71% <0.00%> (ø)
...moveit/distance_field/propagation_distance_field.h 88.64% <ø> (ø)
...e_field/include/moveit/distance_field/voxel_grid.h 95.24% <ø> (ø)
...oveit/kinematic_constraints/kinematic_constraint.h 91.31% <ø> (ø)
...ene/include/moveit/planning_scene/planning_scene.h 50.00% <ø> (ø)
moveit_core/planning_scene/src/planning_scene.cpp 49.52% <0.00%> (ø)
...bot_model/include/moveit/robot_model/joint_model.h 81.95% <ø> (ø)
...del/include/moveit/robot_model/joint_model_group.h 87.18% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3092518...7090f0a. Read the comment docs.

@henningkayser
Copy link
Member

@stephanie-eng I just noticed that there are still plenty of "NULL" mentions in the comments. Shouldn't those be updated as well for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants