Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port controller_manager submodule of moveit_core to ROS 2 #6

Merged
merged 2 commits into from Feb 25, 2019

Conversation

vmayoral
Copy link
Contributor

No description provided.

mlautman
mlautman previously approved these changes Feb 19, 2019
Copy link
Contributor

@mlautman mlautman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the controller manager will still need a replacement for ros::Duration in the waitForExecution method but I assume you will take care of that later on

@vmayoral
Copy link
Contributor Author

It looks like the controller manager will still need a replacement for ros::Duration in the waitForExecution method but I assume you will take care of that later on

that's right, I believe @anasarrak was looking at this aspect this morning. We'll send a PR once it's ready I guess.

*
* The controller is expected to execute the trajectory, but this function call should not block.
* Blocking is achievable by calling waitForExecution().
* Return false when the controller cannot accept the trajectory. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression in commenting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anasarrak can you please review this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davetcoleman davetcoleman merged commit e707d2f into moveit:master Feb 25, 2019
mlautman pushed a commit that referenced this pull request Mar 8, 2019
@anasarrak anasarrak deleted the core-controller-manager branch April 12, 2019 15:50
lilustga referenced this pull request in lilustga/moveit2 Jul 24, 2020
AndyZe referenced this pull request in AndyZe/moveit2 Aug 14, 2021
* set robot state positions/velocities/accelerations from ruckig outout

* updated file name for ruckig traj smoothing

* added plugin for ruckig trajectory smoothing

* removed extra space

* added ruckig to file name and update authors

* deleted unnesessary lines

Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
AndyZe referenced this pull request in AndyZe/moveit2 Aug 21, 2021
* set robot state positions/velocities/accelerations from ruckig outout

* updated file name for ruckig traj smoothing

* added plugin for ruckig trajectory smoothing

* removed extra space

* added ruckig to file name and update authors

* deleted unnesessary lines

Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
AndyZe referenced this pull request in AndyZe/moveit2 Sep 15, 2021
* set robot state positions/velocities/accelerations from ruckig outout

* updated file name for ruckig traj smoothing

* added plugin for ruckig trajectory smoothing

* removed extra space

* added ruckig to file name and update authors

* deleted unnesessary lines

Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
AndyZe added a commit that referenced this pull request Dec 8, 2021
* Install hybrid_planning_demo_node separately to avoid exporting it

* Fix exported include directory

* Remove getTargetWayPointIndex() from abstract trajectory operator class

* Delete unused getTargetWayPointIndex()
galou pushed a commit to galou/moveit2 that referenced this pull request Sep 7, 2022
Fix kdl joint weights and update our branch from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants