Sync with MoveIt #962
Merged
Sync with MoveIt #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we reload these values from the config, setting the ROS parameters is much less useful. At least the *type* of warehouse_ros plugin (mongo or sqlite) cannot be selected in the display, so you will probably need to meddle with the parameters anyway if you want to connect to a different db. search for parameters warehouse_host/port because they are usually set at the top level, but you might want to set them differently for different move_groups.
* Use std::fabs() everywhere * Better comments
- Enable bootstrapping if image doesn't yet exist - Update maintainer for Dockerfiles
The warning message was accessing the config_data_ variable, which was assigned just a few lines later.
Reduce code redundancy, specifying the namespace once in planning_pipeline.launch.
to fix the robostack Windows build
- reordered methods because looking requires replanning - there's no sense in wrapping methods in methods. just use pimpl-friend paradigm instead. Someone could rework all the other methods in the future.
Not an actual bug because both arrays share the same memory. As mentioned in moveit#683 (review)
* Add test case for #2824 Co-authored-by: Cristian Beltran <cristianbehe@gmail.com> Co-authored-by: Joachim Schleicher <joachimsl@gmx.de> Co-authored-by: jschleicher <j.schleicher@pilz.de>
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
==========================================
+ Coverage 57.90% 57.90% +0.01%
==========================================
Files 310 310
Lines 26113 26113
==========================================
+ Hits 15117 15118 +1
+ Misses 10996 10995 -1
Continue to review full report at Codecov.
|
JafarAbdi
reviewed
Jan 5, 2022
henningkayser
approved these changes
Jan 5, 2022
|
@Abishalini this needs to be updated unfortunately with #960 merged |
Abishalini
force-pushed
the
pr-sync-a0ee2020c
branch
from
87ec82d
to
3092518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synced the following commits from MoveIt
Commit 38b3010cb has not been ported to ROS2 and added with other integration tests which are also not ported in PILZ planner.
We could open an issue to port them all in one go