-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named frames to CollisionObjects #50
Add named frames to CollisionObjects #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one correction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally approve this. Not sure yet, whether we really need the ValidateConstraintFrames service.
Shouldn't this be called TransformConstraintFrames, because it's main task is to transform the transforms into known link transforms.
All of the alternatives I could come up with are somewhat imprecise and can be misunderstood. In my mind, the important point is that the constraints are changed from an unusable/invalid state to a formulation that the planner can use. I considered others, too:
I think naming and readibility is important, so I'm all for being verbose if it helps understanding. The function does not come up often anyway, so it won't clog any code. |
This (partially) reverts commit 6350bfb. We keep the improvements in the comments.
This belongs to ros-planning/moveit#1060 and fixes #47 (now properly targets melodic, not kinetic).