Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use occupancy values when saving a map #613

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Use occupancy values when saving a map #613

merged 1 commit into from
Nov 16, 2017

Conversation

allenh1
Copy link
Contributor

@allenh1 allenh1 commented Aug 10, 2017

This is to allow cartographer's maps to be saved.

The occupancy limits are comments within the source, but they are not enforced by the logic they are next to.

@BrannonKing
Copy link

I think you probably want 35 ticks on the low end as well; make it symmetric. I'd go < 35 for line 76.

@mikeferguson
Copy link
Contributor

mikeferguson commented Aug 14, 2017

Has anyone tested this against gmapping and karto? How different does the map look?

@mikeferguson mikeferguson self-assigned this Aug 14, 2017
@allenh1
Copy link
Contributor Author

allenh1 commented Aug 14, 2017

I think you probably want 35 ticks on the low end as well; make it symmetric. I'd go < 35 for line 76.

I've not tested this, but I don't know how that would end up. I'll test with 35 later.

Has anyone tested this against gmapping and karto? How different does the map look?

The maps are not quite what I'm used to for cartographer, but I'm not seeing much of a difference at all from gmapping. In fact, this makes sense if you look at how GMapping publishes its maps.

https://github.com/ros-perception/slam_gmapping/blob/hydro-devel/gmapping/src/slam_gmapping.cpp#L742-L760

@allenh1
Copy link
Contributor Author

allenh1 commented Sep 2, 2017

Update: maps seem fine with GMapping as well. No noticeable difference.

Should I bumpt the lower bound to be < 35 as suggested above?

@allenh1
Copy link
Contributor Author

allenh1 commented Oct 31, 2017

@mikeferguson ping

@DLu DLu merged commit 06c3516 into ros-planning:lunar Nov 16, 2017
@allenh1 allenh1 deleted the use-occupancy-map-saver branch November 16, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants