[ROS 2] Allow Setting Publish Rate for /clock #1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver launch file Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
|
Thanks for the PR! We ended up taking a slightly different approach in #1391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates a params file with the desired clock rate, then passes the file to
gzserveras the contents ofextra_gazebo_args.Signed-off-by: Hunter L. Allen hunter.allen@ghostrobotics.io
This adds
empyas a dependency (which I need to add to thepackage.xml).Other than that, this allows one to pass a publish rate from an external launch file, as requested in #1211, #1247, and #1305.