Fix floating effect with gazebo_ros_planar_move #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
|
@ahcorde 🥺 |
|
CI failed, but I don't see the error in the output 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is related to #372 and fixes #121.
It is ok to command planar speed commands to the robot (x, y, yaw), but if the world is not plane, the robot will float descending slopes.
Current behavior:
Screencast 21-08-23 14:24:40.webm
Behavior with this PR:
Screencast 21-08-23 14:22:55.webm
I hope it helps