Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gazebo_ros] Fix invalid signal name on OS X for script/gazebo #364

Merged
merged 1 commit into from
Oct 26, 2015

Conversation

bgromov
Copy link
Contributor

@bgromov bgromov commented Oct 24, 2015

Fixes the following error on OS X

scripts/gazebo: line 30: kill: SIGINT: invalid signal specification

by feeding system-dependent argument to kill command. On OS X it is kill -s INT instead of kill -s SIGINT.

scripts/gazebo: line 30: kill: SIGINT: invalid signal specification
@scpeters
Copy link
Member

+1

scpeters added a commit that referenced this pull request Oct 26, 2015
[gazebo_ros] Fix invalid signal name on OS X for script/gazebo
@scpeters scpeters merged commit c9ad4df into ros-simulation:jade-devel Oct 26, 2015
@scpeters
Copy link
Member

Thanks! I cherry-picked to indigo-devel in 03a1e27

@bgromov bgromov deleted the fix_gazebo_sigint_osx branch October 27, 2015 11:55
@dirk-thomas
Copy link
Collaborator

dirk-thomas commented Jul 7, 2016

For me on Xenial I do have the same problem. When running the gazeboscript it fails to kill gzserver at the end with the following error message:

kill: invalid signal number or name: SIGINT

When changing the signal name to INT (as this PR does for OS X) it works for me on Xenial.

Another reference mentioning this: http://stackoverflow.com/questions/16423732/linux-shell-kill-signal-sigkill-kill

@dirk-thomas
Copy link
Collaborator

@nkoenig just mentioned to me that the problem will be addressed by #472 (and a new patch release of Gazebo 7).

@scpeters
Copy link
Member

scpeters commented Jul 8, 2016

I'm not sure if #472 will help, since it wouldn't work with the upstream Ubuntu gazebo 7.0.0

what if we just switch to kill -n 2 instead of trying to name the signal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants