Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node_name from <ros> SDF tag #804

Merged
merged 7 commits into from
Aug 28, 2018
Merged

Remove node_name from <ros> SDF tag #804

merged 7 commits into from
Aug 28, 2018

Conversation

dhood
Copy link
Collaborator

@dhood dhood commented Aug 24, 2018

In progress

@dhood dhood added the ros2 label Aug 24, 2018
@chapulina
Copy link
Contributor

@ros-pull-request-builder retest this please

@chapulina chapulina changed the base branch from ros2_conversion_deps_fix to ros2 August 28, 2018 18:03
chapulina
chapulina approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All points on #797 have been addressed.

@chapulina chapulina merged commit 46d4e34 into ros2 Aug 28, 2018
@chapulina chapulina deleted the ros2_update_sdf branch August 28, 2018 22:24
@chapulina chapulina mentioned this pull request Aug 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhood @chapulina