Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to publish depth images in 16UC1 #862

Merged
merged 3 commits into from May 15, 2020

Conversation

awesomebytes
Copy link
Contributor

Given there are sensors in robots that publish depth images natively in the 16UC1 format, it is convenient to be able to simulate it instead of converting manually later on from 32FC1.

@awesomebytes
Copy link
Contributor Author

I don't know why ros_gazebo_pkgs-ci-pr_any_kinetic-xenial-amd64 is failing on the tests:

  • DistortionTest.barrelDistortion
  • DistortionTest.pincushionDistortion
  • TriggeredCameraTest.cameraSubscribeTest

Given I haven't changed anything related to them (I think). Let me know if I can do anything to fix it.

@sloretz sloretz changed the base branch from kinetic-devel to noetic-devel May 15, 2020 03:13
@sloretz
Copy link
Contributor

sloretz commented May 15, 2020

Closing/reopening to see if github sorts out that only 3 commits need to be added

@sloretz sloretz closed this May 15, 2020
@sloretz sloretz reopened this May 15, 2020
@sloretz
Copy link
Contributor

sloretz commented May 15, 2020

@awesomebytes I rebased your branch onto noetic-devel, hope you don't mind.

@awesomebytes
Copy link
Contributor Author

@sloretz sounds great! I'd love to see this merged :)

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for waiting to get it into Noetic. LGTM.

@chapulina chapulina merged commit 241b4e3 into ros-simulation:noetic-devel May 15, 2020
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
Add option to publish depth images in 16UC1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants