Camera optical frame #959
Open
Camera optical frame #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2019 16:36
chapulina
reviewed
Dec 23, 2019
| @@ -139,8 +140,14 @@ namespace gazebo | |||
| protected: common::Time last_info_update_time_; | |||
|
|
|||
| /// \brief ROS frame transform name to use in the image message header. | |||
| /// This should typically match the link name the sensor is attached. | |||
| /// This should typically match the link name the parent sensor + "_optical". | |||
| protected: std::string frame_name_; | |||
There was a problem hiding this comment.
It looks like the documentation for frame_name_ and frame_name_optical_ is mixed up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to VRX Issue#140 at https://bitbucket.org/osrf/vrx/issues/140/there-is-no-camera-optical-link . With this pull request Gazebo Ros Cameras (and only Gazebo Ros Camera) now published the transform the the optical frame.