Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower scheduled jobs frequency #593

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Lower scheduled jobs frequency #593

merged 1 commit into from
Mar 22, 2021

Conversation

christophebedard
Copy link
Member

Tests take sometimes more than an hour to complete, so hourly scheduled jobs gets backed up. This gets even worse when dependabot opens a bunch of PRs every day.

This has led to PR tests being queued for 10h+.

I am proposing to reduce the frequency to twice per day, but anything less frequent than hourly (every 2-4h) would help.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard requested a review from a team as a code owner March 22, 2021 15:36
@christophebedard christophebedard requested review from thomas-moulard and lucashan and removed request for a team March 22, 2021 15:36
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me, it really doesn't need to run every hour

@emersonknapp emersonknapp enabled auto-merge (squash) March 22, 2021 17:36
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #593 (69ef669) into master (2466232) will decrease coverage by 0.90%.
The diff coverage is n/a.

❗ Current head 69ef669 differs from pull request most recent head da0f8ca. Consider uploading reports for the commit da0f8ca to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   38.63%   37.72%   -0.91%     
==========================================
  Files           2        2              
  Lines         220      220              
  Branches       41       41              
==========================================
- Hits           85       83       -2     
- Misses        135      137       +2     
Impacted Files Coverage Δ
src/action-ros-ci.ts 28.27% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2466232...da0f8ca. Read the comment docs.

@emersonknapp emersonknapp merged commit 3018c9a into ros-tooling:master Mar 22, 2021
@christophebedard christophebedard deleted the cron-schedule-reduce branch March 22, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants