-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iron to valid distros #823
Add Iron to valid distros #823
Conversation
ROS 2 Iron has been released Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
77adb9b
to
4d807a1
Compare
@Karsten1987 are you really still a code owner on this 🤣 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 47.87% 47.87%
=======================================
Files 2 2
Lines 282 282
Branches 76 76
=======================================
Hits 135 135
Misses 147 147
☔ View full report in Codecov by Sentry. |
It would be good to add Iron to the test matrices. At least here for now: action-ros-ci/.github/workflows/test.yml Lines 230 to 239 in fc52906
I can update the rest later. |
Yeh I can also peel out all the EOL distros if you’d like. |
I can remove Melodic and Foxy a bit later, since they aren't technically EOL yet. |
Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Followed steps from DEVELOPING.md Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the PR! The one CI job failure is just a flake.
I'll create a new release right after this.
Released as |
ROS 2 Iron has been released