Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iron to valid distros #823

Merged

Conversation

moriarty
Copy link
Contributor

ROS 2 Iron has been released

@moriarty moriarty requested a review from a team as a code owner May 27, 2023 00:28
@moriarty moriarty requested review from gbiggs and Karsten1987 and removed request for a team May 27, 2023 00:28
ROS 2 Iron has been released

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
@moriarty moriarty force-pushed the add-iron-to-valid-ros2-distros branch from 77adb9b to 4d807a1 Compare May 27, 2023 00:28
@moriarty
Copy link
Contributor Author

@Karsten1987 are you really still a code owner on this 🤣

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc52906) 47.87% compared to head (53034ab) 47.87%.

❗ Current head 53034ab differs from pull request most recent head 2798194. Consider uploading reports for the commit 2798194 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   47.87%   47.87%           
=======================================
  Files           2        2           
  Lines         282      282           
  Branches       76       76           
=======================================
  Hits          135      135           
  Misses        147      147           
Impacted Files Coverage Δ
src/action-ros-ci.ts 41.89% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christophebedard
Copy link
Member

christophebedard commented May 27, 2023

It would be good to add Iron to the test matrices. At least here for now:

matrix:
os: [macOS-latest, windows-2019, ubuntu-20.04, ubuntu-22.04]
ros_distribution: [foxy, humble, rolling]
exclude:
- os: ubuntu-22.04
ros_distribution: foxy
- os: ubuntu-20.04
ros_distribution: humble
- os: ubuntu-20.04
ros_distribution: rolling

I can update the rest later.

@moriarty
Copy link
Contributor Author

It would be good to add Iron to the test matrices. At least here for now:

matrix:
os: [macOS-latest, windows-2019, ubuntu-20.04, ubuntu-22.04]
ros_distribution: [foxy, humble, rolling]
exclude:
- os: ubuntu-22.04
ros_distribution: foxy
- os: ubuntu-20.04
ros_distribution: humble
- os: ubuntu-20.04
ros_distribution: rolling

I can update the rest later.

Yeh I can also peel out all the EOL distros if you’d like.

@christophebedard
Copy link
Member

Yeh I can also peel out all the EOL distros if you’d like.

I can remove Melodic and Foxy a bit later, since they aren't technically EOL yet.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Followed steps from DEVELOPING.md

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! The one CI job failure is just a flake.

I'll create a new release right after this.

@christophebedard christophebedard merged commit e83659a into ros-tooling:master May 30, 2023
@christophebedard
Copy link
Member

Released as 0.3.1/v0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants