Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read the GitHub server URL from the 'GITHUB_SERVER_URL' env variable #835

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

christian-rauch
Copy link
Contributor

This PR replaces the hardcoded URL https://github.com with the content of the environment variable GITHUB_SERVER_URL in order to allow using this action on GitHub Enterprise instances. Fixes #831.

@christian-rauch christian-rauch requested a review from a team as a code owner November 9, 2023 07:58
@christian-rauch christian-rauch requested review from gbiggs and jhdcs and removed request for a team November 9, 2023 07:58
Signed-off-by: Christian Rauch <Christian.Rauch@de.bosch.com>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (38c12d5) 47.70% compared to head (cf47ae0) 47.53%.

❗ Current head cf47ae0 differs from pull request most recent head e904bd1. Consider uploading reports for the commit e904bd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   47.70%   47.53%   -0.17%     
==========================================
  Files           2        2              
  Lines         283      284       +1     
  Branches       77       77              
==========================================
  Hits          135      135              
- Misses        148      149       +1     
Files Coverage Δ
src/action-ros-ci.ts 41.56% <0.00%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

I see the same macOS failures in the nightly CI jobs.

@christophebedard christophebedard merged commit 67b4ac4 into ros-tooling:master Nov 9, 2023
27 of 29 checks passed
@christophebedard
Copy link
Member

I released this as 0.3.5/v0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong URL for GitHub Enterprise repos
2 participants