This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
Package selection & build customization via colcon defaults file #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 93.85% 93.91% +0.05%
==========================================
Files 7 7
Lines 228 230 +2
==========================================
+ Hits 214 216 +2
Misses 14 14
Continue to review full report at Codecov.
|
emersonknapp
force-pushed
the
emersonknapp/colcon-defaults
branch
from
93a340b
to
d872278
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/colcon-defaults
branch
from
ac779cf
to
d8ea0e8
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/colcon-defaults
branch
from
8d51b87
to
bb1c9bd
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
changed the title
emersonknapp
requested review from
prajakta-gokhale,
thomas-moulard,
zmichaels11 and
piraka9011
piraka9011
reviewed
Mar 7, 2020
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
zmichaels11
approved these changes
Mar 9, 2020
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Allow users to pass arbitrary arguments to the
colcon listandcolcon buildphases. This allows for arbitrary build customization, so I have removed the hardcoding ofmerge-install