-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move colcon from apt to pip #46
Conversation
LGTM |
9bc4164
to
a9fccd2
Compare
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
a9fccd2
to
32e0e7d
Compare
Why are we pinning colcon versions? It seems like this is likely to cause trouble since the tutorial recommends installing via either apt or pip3, and these pinned versions match neither release. https://index.ros.org/doc/ros2/Tutorials/Colcon-Tutorial/ Are upstream colcon changes breaking the build a common problem? |
Here's the type of problems this causes when trying to use CI to test colcon changes: https://github.com/rotu/colcon-cmake/runs/1022561615?check_suite_focus=true#step:8:6641
|
This PR moves the installation of
colcon
and associated extensions fromapt
topip
in order to lock down the version ofcolcon
+ extensions and avoid breaking changes from upstream.Tests for this are being run here.
Signed-off-by: Anas Abou Allaban allabana@amazon.com