Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to ROS 2 #44

Merged
merged 54 commits into from
Aug 30, 2019
Merged

Port to ROS 2 #44

merged 54 commits into from
Aug 30, 2019

Commits on Jul 24, 2019

  1. Rough port of interactive marker server 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz @jacobperron
    sloretz authored and jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    a99e75a View commit details
    Browse the repository at this point in the history

  2. Rename headers 

    Now with .hpp suffix

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    aebb97f View commit details
    Browse the repository at this point in the history

  3. [WIP] Get client to compile 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    2ee853e View commit details
    Browse the repository at this point in the history

  4. Client compiling 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    226a4e0 View commit details
    Browse the repository at this point in the history

  5. Cleanup package.xml 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    79dfc02 View commit details
    Browse the repository at this point in the history

  6. Add linter tests 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    5a4b6f0 View commit details
    Browse the repository at this point in the history

  7. Uncrustify 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    31f6056 View commit details
    Browse the repository at this point in the history

  8. Lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    754009a View commit details
    Browse the repository at this point in the history

  9. Do not run flake8 linter test 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    1729212 View commit details
    Browse the repository at this point in the history

  10. Add LICENSE and CONTRIBUTING.md 

    This satisfies the ament_copyright linter.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    3c446ea View commit details
    Browse the repository at this point in the history

  11. Fix deprecation warning 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    b477c55 View commit details
    Browse the repository at this point in the history

  12. Use rcutils log macro instead of custom macro 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    17d934f View commit details
    Browse the repository at this point in the history

  13. Use tf2::BufferCoreInterface 

    Using this abstract interface enables use of the interactive marker client with other buffer implementations.

Also, switched to using shared pointers to avoid potential dangling reference.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    c34da0e View commit details
    Browse the repository at this point in the history

  14. Replace 'init' topic with a ROS service 

    It seems more intuitive for clients to call a service to get the latest state for interactive
markers, versus subscribing to a latched topic and waiting for the server to publish.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    a33aae0 View commit details
    Browse the repository at this point in the history

  15. Add tests for InteractiveMarkerServer 

    Failing tests are commented out for now.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    816b857 View commit details
    Browse the repository at this point in the history

  16. Lint after rebase 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    a1466fc View commit details
    Browse the repository at this point in the history

  17. Add getter for client state 

    Useful for introspection, especially during testing.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    79062ce View commit details
    Browse the repository at this point in the history

  18. Wait for service to be ready during INIT state 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    bf72f64 View commit details
    Browse the repository at this point in the history

  19. Add tests for InteractiveMarkerClient + fix tf2 dependency 

    Failing tests are commented out.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    bedff88 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. Minor refactoring 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    980f1cb View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Major refactor 

    Merge SingleClient logic into InteractiveMarkerClient.
Now it is assumed that there is maximum one server per client.
This helps simplify the implementation.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7eaeeab View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. More refactoring 

    * Update doc-block comment style
* Fix tests
* Renaming of variables for clarity

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    7be1215 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Remove old test code and unused single_client.hpp 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    2663078 View commit details
    Browse the repository at this point in the history

  2. Refactor tools docs 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    1bb72aa View commit details
    Browse the repository at this point in the history

  3. Remove notion of server ID 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    715ff69 View commit details
    Browse the repository at this point in the history

  4. Add missing MockInteractiveMarkerServer 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    e06f1ce View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Refactor interactive marker client docs 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    05639e4 View commit details
    Browse the repository at this point in the history

  2. Update copyright license 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    b840d10 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Reduce spam 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    e7e2b16 View commit details
    Browse the repository at this point in the history

  2. Make shared library 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    a94e65e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Guard against invalid namespace 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    bbf7f8f View commit details
    Browse the repository at this point in the history

  2. Add feedback publisher to client 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    6d6da9f View commit details
    Browse the repository at this point in the history

  3. Call reset callback 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    2f1dd42 View commit details
    Browse the repository at this point in the history

  4. Add reset callback test and fix deconstructor bug 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    7dc225c View commit details
    Browse the repository at this point in the history

  5. Implement client request timeout 

    If a response for the request isn't received within the provided timeout, then try again.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    e5d7ebf View commit details
    Browse the repository at this point in the history

  6. Add logic for 'extrapolation into future' error 

    Rename custom exception and throw it in replace of tf2 exceptions.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    14fef39 View commit details
    Browse the repository at this point in the history

  7. Update TODO 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    b7b6f25 View commit details
    Browse the repository at this point in the history

  8. Add missing test depend on ament_cmake_gtest 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    b42ce43 View commit details
    Browse the repository at this point in the history

  9. Default to C++14 and set stricter compiler flags 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    1e90766 View commit details
    Browse the repository at this point in the history

  10. Fix compiler warnings 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    f95a235 View commit details
    Browse the repository at this point in the history

  11. Fix Windows compiler warnings 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    5d01022 View commit details
    Browse the repository at this point in the history

  12. Remove StateMachine class 

    The functionality it provided is not needed.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    12cabda View commit details
    Browse the repository at this point in the history

  13. Fix Clang warnings 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    aae3258 View commit details
    Browse the repository at this point in the history

  14. Remove include 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    762c72c View commit details
    Browse the repository at this point in the history

  15. Move message context header into same directory as other headers 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    1f6ed3a View commit details
    Browse the repository at this point in the history

  16. Revert "Fix Clang warnings" 

    This reverts commit aae3258.
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    4f41d7f View commit details
    Browse the repository at this point in the history

  17. Use uint64_t type specifier 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    0dc3cef View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Attempt to resolve Windows build failure 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    5891e0e View commit details
    Browse the repository at this point in the history

  2. Workaround windows preprocessor 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    5507bf1 View commit details
    Browse the repository at this point in the history

  3. Use visibility macros 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    09b26b4 View commit details
    Browse the repository at this point in the history

  4. Fix conversion warnings 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    1ca267b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Fix visibility macro usage 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    f8ea7dc View commit details
    Browse the repository at this point in the history

  2. Fix MSVC warnings 

    Adding UNUSED macro arguments fixes "too many arguments" and "too few
arguments" warnings.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    063b0e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Change error message to avoid false positive due to bug in CI setup 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    899bb0f View commit details
    Browse the repository at this point in the history