Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing auto lint tests and making one flake8 change #55

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@brawner
Copy link

commented Nov 20, 2018

This removes the added python style check files in favor of ament_lint_auto. It also fixes one flake8 issue that snuck through.

CI test
https://ci.ros2.org/job/ci_linux/5596

19:48:30 ==> /home/rosbuild/ci_scripts/venv/bin/colcon test-result --test-result-base "build" --all
19:48:30 build/python_qt_binding/test_results/python_qt_binding/flake8.xunit.xml: 1 test, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/lint_cmake.xunit.xml: 3 tests, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/pep257.xunit.xml: 4 tests, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/xmllint.xunit.xml: 1 test, 0 errors, 0 failures, 0 skipped
19:48:30 
19:48:30 Summary: 9 tests, 0 errors, 0 failures, 0 skipped

@brawner brawner requested review from dirk-thomas and mlautman Nov 20, 2018

@wafflebot wafflebot bot added the in progress label Nov 20, 2018

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Why should the imports test be removed again?

@brawner brawner force-pushed the lint_fix branch 3 times, most recently from 9a1e316 to ce483bd Nov 20, 2018

@brawner brawner force-pushed the lint_fix branch from ce483bd to 2736853 Nov 20, 2018

@brawner

This comment has been minimized.

Copy link
Author

commented Nov 20, 2018

@dirk-thomas Gah, it shouldn't have been. I've restored that test.

@brawner brawner merged commit 0539c9e into crystal-devel Nov 20, 2018

@wafflebot wafflebot bot removed the in progress label Nov 20, 2018

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Please use squash merge and delete obsolete branches afterwards.

@dirk-thomas dirk-thomas deleted the lint_fix branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.