Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing auto lint tests and making one flake8 change #55

Merged
merged 1 commit into from Nov 20, 2018
Merged

Fixing auto lint tests and making one flake8 change #55

merged 1 commit into from Nov 20, 2018

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Nov 20, 2018

This removes the added python style check files in favor of ament_lint_auto. It also fixes one flake8 issue that snuck through.

CI test
https://ci.ros2.org/job/ci_linux/5596

19:48:30 ==> /home/rosbuild/ci_scripts/venv/bin/colcon test-result --test-result-base "build" --all
19:48:30 build/python_qt_binding/test_results/python_qt_binding/flake8.xunit.xml: 1 test, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/lint_cmake.xunit.xml: 3 tests, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/pep257.xunit.xml: 4 tests, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/xmllint.xunit.xml: 1 test, 0 errors, 0 failures, 0 skipped
19:48:30 
19:48:30 Summary: 9 tests, 0 errors, 0 failures, 0 skipped

@ghost ghost assigned brawner Nov 20, 2018
@ghost ghost added the in progress label Nov 20, 2018
@dirk-thomas
Copy link
Contributor

Why should the imports test be removed again?

@brawner brawner force-pushed the lint_fix branch 3 times, most recently from 9a1e316 to ce483bd Compare November 20, 2018 20:42
@brawner
Copy link
Contributor Author

brawner commented Nov 20, 2018

@dirk-thomas Gah, it shouldn't have been. I've restored that test.

@brawner brawner merged commit 0539c9e into crystal-devel Nov 20, 2018
@ghost ghost removed the in progress label Nov 20, 2018
@dirk-thomas
Copy link
Contributor

Please use squash merge and delete obsolete branches afterwards.

@dirk-thomas dirk-thomas deleted the lint_fix branch November 20, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@mlautman mlautman mlautman approved these changes

Assignees

@brawner brawner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brawner @dirk-thomas @mlautman