Migrate tinyxml2 #147
Merged
Migrate tinyxml2 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
brawner
force-pushed
the
migrate_tinyxml2
branch
4 times, most recently
from
58ae669
to
b0a3a25
Compare
dirk-thomas
reviewed
Nov 30, 2018
dirk-thomas
reviewed
Nov 30, 2018
|
The rosdep key exists
https://github.com/ros/rosdistro/blob/55d26753612d93f2d915e99b8b068626928e4fb9/rosdep/base.yaml#L4917
…On Fri, Nov 30, 2018 at 12:13 PM Dirk Thomas ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In qt_gui_cpp/package.xml
<#147 (comment)>
:
> @@ -21,13 +21,13 @@
<build_depend version_gte="0.3.0">python_qt_binding</build_depend>
<build_depend>qt5-qmake</build_depend>
<build_depend>qtbase5-dev</build_depend>
- <build_depend>tinyxml_vendor</build_depend>
- <build_depend>tinyxml</build_depend>
+ <build_depend>tinyxml2_vendor</build_depend>
+ <build_depend>tinyxml2</build_depend>
I don't think there is a ROS package named tinyxml2?
Same below.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#147 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_x-gaoG-_iwsxdFx-Xc7lRNNHXP1cbks5u0ZFRgaJpZM4Y7LFd>
.
|
|
But you don't use/need it anywhere? |
Merged
brawner
force-pushed
the
migrate_tinyxml2
branch
from
b0a3a25
to
5476761
Compare
brawner
force-pushed
the
migrate_tinyxml2
branch
from
5476761
to
5456403
Compare
dirk-thomas
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the TinyXml dependency to TinyXMl2, which is better supported by ROS2 across the different platforms (esp Windows).