add missing tinyxml include #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas Do you think this will also make it in the groovy-devel branch that is used for indigo releases ? |
|
Sure, if it needs to. |
|
That would be great, that would allow me to migrate pluginlib to tinyxml2 without having to branch out for indigo |
|
Actually this patch might also need changes to the CMake file to fin TinyXML on its own since |
|
good point, a follow up patch is available in #97 |
|
@mikaelarguedas I guess with ros/pluginlib#58 this doesn't need to be backported to Indigo / Jade? |
|
Exactly, I was about to comment here. Indeed this doesn't need to be backported for indigo and jade anymore, sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package declares a build dependency on tinyxml but relies on
<pluginlib/class_loader.h>to include it.