Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize topics being published and highlight topic being selected #116

Merged
merged 6 commits into from
Jul 12, 2022

Conversation

ivanpauno
Copy link

@ivanpauno ivanpauno commented Jul 6, 2022

Depends on #115. Integrated those changes there to avoid generating conflicts.
The boxes can be clicked to activate/deactivate publishing that topic.

Screenshot from 2022-07-11 13-11-53

highlighted topic:
image

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…them on the widget

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/visualize-topics-being-published branch from e25566f to 6067cef Compare July 8, 2022 18:10
@ivanpauno ivanpauno changed the title Visualize topics being published Visualize topics being published and highlight topic being selected Jul 8, 2022
@ivanpauno ivanpauno changed the base branch from ivanpauno/fixes-3 to ros2 July 8, 2022 18:11
@ivanpauno ivanpauno requested a review from wjwwood July 8, 2022 18:18
rqt_bag/src/rqt_bag/timeline_frame.py Outdated Show resolved Hide resolved
rqt_bag/src/rqt_bag/timeline_frame.py Outdated Show resolved Hide resolved
rqt_bag/src/rqt_bag/timeline_frame.py Outdated Show resolved Hide resolved
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno requested a review from wjwwood July 11, 2022 16:15
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanpauno
Copy link
Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 0dd721d into ros2 Jul 12, 2022
@ivanpauno ivanpauno deleted the ivanpauno/visualize-topics-being-published branch July 12, 2022 21:40
@ivanpauno
Copy link
Author

Merged, thanks for the reviews @wjwwood !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants