autopep8 #19
Merged
autopep8 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
reviewed
Oct 17, 2018
src/rqt_graph/dotcode.py
Outdated
| + [action_prefix + ACTION_TOPICS_SUFFIX for (action_prefix, _) in action_nodes.items()] | ||
| + [image_prefix + IMAGE_TOPICS_SUFFIX for (image_prefix, _) in image_nodes.items()] | ||
| + nn_nodes if nn_nodes is not None else [], | ||
| + [action_prefix + ACTION_TOPICS_SUFFIX for (action_prefix, _) in action_nodes.items()] |
There was a problem hiding this comment.
This list should probably not be built inside the call to _populate_node_graph
src/rqt_graph/ros_graph.py
Outdated
| @@ -331,7 +344,8 @@ def _redraw_graph_view(self): | |||
|
|
|||
| def _load_dot(self, file_name=None): | |||
| if file_name is None: | |||
| file_name, _ = QFileDialog.getOpenFileName(self._widget, self.tr('Open graph from file'), None, self.tr('DOT graph (*.dot)')) | |||
| file_name, _ = QFileDialog.getOpenFileName(self._widget, self.tr( | |||
| 'Open graph from file'), None, self.tr('DOT graph (*.dot)')) | |||
src/rqt_graph/ros_graph.py
Outdated
| @@ -363,7 +377,8 @@ def _fit_in_view(self): | |||
| self._widget.graphics_view.fitInView(self._scene.itemsBoundingRect(), Qt.KeepAspectRatio) | |||
|
|
|||
| def _save_dot(self): | |||
| file_name, _ = QFileDialog.getSaveFileName(self._widget, self.tr('Save as DOT'), 'rosgraph.dot', self.tr('DOT graph (*.dot)')) | |||
| file_name, _ = QFileDialog.getSaveFileName(self._widget, self.tr( | |||
| 'Save as DOT'), 'rosgraph.dot', self.tr('DOT graph (*.dot)')) | |||
src/rqt_graph/ros_graph.py
Outdated
| @@ -375,7 +390,8 @@ def _save_dot(self): | |||
| handle.close() | |||
|
|
|||
| def _save_svg(self): | |||
| file_name, _ = QFileDialog.getSaveFileName(self._widget, self.tr('Save as SVG'), 'rosgraph.svg', self.tr('Scalable Vector Graphic (*.svg)')) | |||
| file_name, _ = QFileDialog.getSaveFileName(self._widget, self.tr( | |||
| 'Save as SVG'), 'rosgraph.svg', self.tr('Scalable Vector Graphic (*.svg)')) | |||
src/rqt_graph/ros_graph.py
Outdated
| @@ -389,7 +405,8 @@ def _save_svg(self): | |||
| painter.end() | |||
|
|
|||
| def _save_image(self): | |||
| file_name, _ = QFileDialog.getSaveFileName(self._widget, self.tr('Save as image'), 'rosgraph.png', self.tr('Image (*.bmp *.jpg *.png *.tiff)')) | |||
| file_name, _ = QFileDialog.getSaveFileName(self._widget, self.tr( | |||
| 'Save as image'), 'rosgraph.png', self.tr('Image (*.bmp *.jpg *.png *.tiff)')) | |||
test/dotcode_test.py
Outdated
| ) | ||
| edges, | ||
| node_connections, | ||
| True, # hide_single_connection_topics, |
test/dotcode_test.py
Outdated
| edges, | ||
| node_connections, | ||
| True, # hide_single_connection_topics, | ||
| False # hide_dead_end_topics |
There was a problem hiding this comment.
use a named parameter instead of a comment
test/dotcode_test.py
Outdated
| ) | ||
| edges, | ||
| node_connections, | ||
| False, # hide_single_connection_topics, |
test/dotcode_test.py
Outdated
| ) | ||
| edges, | ||
| node_connections, | ||
| True, # hide_single_connection_topics, |
mlautman
force-pushed
the
pep8
branch
3 times, most recently
from
50bfe39
to
c71c112
Compare
|
@brawner all good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of running
autopep8 --max-line-length 130 --in-place $1on each.pyfile