Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robot: check for root_link_ before use (kinetic port of #1039) #1041

Merged

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Aug 22, 2016

I noticed that @wjwwood added "needs forward port" to #1039.
If he'd just asked I would have provided the request directly...

A couple of lines below the code accesses link->getChildJointNames()
without testing "link". The additional test guarantees the link is set
before working with it.

I noticed that when adding support to MoveIt to correctly initialize
an empty robot model after printing an error.
@trainman419
Copy link
Contributor

It's roughly equal effort for @wjwwood to cherry-pick patches made on an older branch onto the kinetic branch or for him to handle a pull request. I think he usually does the forward ports in batches as preparation for a new release of rviz.

This isn't an underhanded or passive-aggressive request for a forward port; it's a note-to-self that #1039 needs to be cherry-picked in before the next kinect release.

This pull request is still fine if you'd like to see #1039 incorporated into the kinetic branch sooner.

@v4hn
Copy link
Contributor Author

v4hn commented Aug 25, 2016

On Wed, Aug 24, 2016 at 02:41:50PM -0700, Austin wrote:

This pull request is still fine if you'd like to see #1039 incorporated into the kinetic branch sooner.

That was the hope, yes.
On the other hand, one of our patches in MoveIt depends on this request being actually released in RViz.
So we wait for the release either way.

Thanks for the explanation Austin.

@wjwwood
Copy link
Member

wjwwood commented Oct 17, 2016

Yeah, sorry I just put those labels on so I can handle it when doing a release. Thanks for doing for me though.

@wjwwood wjwwood merged commit 61950e9 into ros-visualization:kinetic-devel Oct 17, 2016
130s pushed a commit to 130s/rviz that referenced this pull request Aug 21, 2024
…1041) (ros-visualization#1046)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 7a2a6bc2e9cd8df996d7f320ef8c166638691d47)

Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants