Skip to content

unified find_package for Qt4 and Qt5 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2016

Conversation

rhaschke
Copy link
Contributor

As the tutorial probably will serve as a template for many other plugins, I suggest this more uniform find_package usage for Qt4 and Qt5.
Also, shouldn't we insist in the very same Qt version, i.e. using EXACT?

@rhaschke
Copy link
Contributor Author

The Travis error seems to be unrelated to my changes: rosdep cannot install libqt5widgets5:

executing command [sudo -H apt-get install -y libqt5widgets5]
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Unable to locate package libqt5widgets5

@wjwwood
Copy link
Member

wjwwood commented Apr 24, 2016

Yeah, I'll have to fix the CI.

@wjwwood
Copy link
Member

wjwwood commented Apr 25, 2016

@rhaschke can you rebase this so the CI is fixed?

@rhaschke
Copy link
Contributor Author

@wjwwood Rebased. CI successfully built.

@wjwwood
Copy link
Member

wjwwood commented Apr 25, 2016

Thanks.

@wjwwood wjwwood merged commit 4607520 into ros-visualization:kinetic-devel Apr 25, 2016
@rhaschke rhaschke deleted the unify_find_qt branch April 3, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants