Python Version of Angles.h #7
Conversation
| #********************************************************************* | ||
| # Software License Agreement (BSD License) | ||
| # | ||
| # Copyright (c) 2008, Willow Garage, Inc. |
There was a problem hiding this comment.
Copied from here: https://github.com/ros/angles/blob/master/angles/include/angles/angles.h
What is the policy for updating Willow Garage copyrights? Nav stack is full of them.
There was a problem hiding this comment.
You wrote the new code. You get the copyright (though if you're working for a company you may be required to give it to them.). And it should be dated the year written.
When you significantly edit a file, you should add the name and year at the top to a list in the header.
|
Figuring out the license was a longer process than I thought. Ready for review again. |
|
|
||
| return 2*pi | ||
|
|
||
| def find_min_max_delta(from_angle, left_limit, right_limit): |
There was a problem hiding this comment.
This would be great to prefix with an underscore to signify that it's not public API.
|
Thanks for resolving the license. One comment on the function name but otherwise lgtm. Especially thanks for all the unit tests. |
|
Sorry, I just got the PR build test working and forgot about the one change requested. Could you tweak that an open a new PR? |
It's always bothered me that this doesn't exist.
I'm not entirely certain I did the test setup correct, but it does pass when run manually.