Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find uuid correctly on ubuntu and osx #55

Merged
merged 1 commit into from
Feb 21, 2020
Merged

find uuid correctly on ubuntu and osx #55

merged 1 commit into from
Feb 21, 2020

Conversation

Karsten1987
Copy link

@Karsten1987 Karsten1987 commented Sep 11, 2019 •
edited
Loading

attempt to fix the broken build of the ros2 branch

  • correctly finding the uuid libraries on osx and ubuntu
  • finding RPC on windows (TODO)

@Karsten1987
Copy link
Author

Idea: we can use uuid on non Windows devices and replace RPC on windows with something similar to what is done in rclcpp with std::generate.
https://github.com/ros2/rclcpp/blob/64c0f86f14dfe2337816079c4d5991268aeb0635/rclcpp_action/src/client.cpp#L369-L381

However, having a solution on how to find rpcrt4.dll in cmake would be prefered I think.

@Karsten1987
Copy link
Author

@mjcarroll friendly ping. This PR is needed for ros/diagnostics#118

@mjcarroll mjcarroll merged commit bad42f4 into ros:ros2 Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @mjcarroll