Cmake modules uuid #8
Conversation
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| <build_depend>bond</build_depend> | |||
| <build_depend>boost</build_depend> | |||
| <build_depend>cmake_modules</build_depend> | |||
There was a problem hiding this comment.
This needs a version dependency.
There was a problem hiding this comment.
ros/cmake_modules would need a new release, @wjwwood could you release it? This looks like an important fix for all Yosemite users.
There was a problem hiding this comment.
Version 0.3.2 now have pending releases for,
|
Why do a 1.7.14 before the changes? |
|
@dirk-thomas I don't really know why the diff shows that, bond_core is already at 1.7.14 |
|
You might want to make sure that the 1.7.14 commit is not part of this PR. From https://github.com/ros/bond_core/commits/cmake-modules-uuid it looks like that you have recommitted the 1.7.14 comit on the branch 4 days ago. |
esteve
force-pushed
the
cmake-modules-uuid
branch
from
14ea598
to
f4265d6
Compare
|
@dirk-thomas Fixed, rebased against master. |
| @@ -2,20 +2,16 @@ cmake_minimum_required(VERSION 2.8.3) | |||
| project(bondcpp) | |||
|
|
|||
| find_package(Boost REQUIRED) | |||
| find_package(catkin REQUIRED bond roscpp smclib) | |||
| find_package(catkin REQUIRED bond roscpp smclib cmake_modules) | |||
There was a problem hiding this comment.
You should add cmake_modules in alphabetical order.
Use cmake_modules to find the UUID libraries.
Solves #6
Depends on ros/cmake_modules@b45081a