Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use #pragma message() to print out warning in MSVC #114

Merged
merged 3 commits into from
Jan 31, 2019

Conversation

kejxu
Copy link
Contributor

@kejxu kejxu commented Jan 18, 2019

#warning does not work on MSVC, add #ifdef _MSC_VER block to add MSVC equivalent:

#pragma message(<warning>)

this only adds special handling for MSVC scenario, does not change Linux logics

nuclearsandwich added a commit to nuclearsandwich/class_loader that referenced this pull request Jan 30, 2019
@nuclearsandwich
Copy link
Member

Note for maintainers: Since this deprecated header is not present in ROS 2 there's no need to port this change forward.

@nuclearsandwich nuclearsandwich merged commit 6a2dee1 into ros:melodic-devel Jan 31, 2019
@kejxu kejxu deleted the use_#pragma_message_for_msvc branch January 31, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants