Fix find Poco to return full lib path #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,7 +169,8 @@ IF(Poco_INCLUDE_DIR) | |||
| FOREACH(COMPONENT ${Poco_FIND_COMPONENTS}) | |||
| FIND_LIBRARY(LIB${COMPONENT} "Poco${COMPONENT}" Poco_LIBRARY_DIR) | |||
| IF (LIB${COMPONENT}) | |||
| LIST(APPEND Poco_LIBRARIES "Poco${COMPONENT}${DBG}") | |||
| # LIST(APPEND Poco_LIBRARIES "Poco${COMPONENT}${DBG}") | |||
There was a problem hiding this comment.
Should go away. We have the git history for that.
|
I updated the pull request. |
|
It builds on OS X, I haven't tested Linux. |
|
@dirk-thomas @mirzashah Can I get a review/merge on this? |
|
With the debug suffix being readded +1 |
|
It builds on linux with for me and passes all unit tests |
mirzashah
pushed a commit
that referenced
this pull request
Jul 2, 2013
Fix find Poco to return full lib path
|
This needs to get merged into hydro-devel! I probably opened against the wrong branch, or the hydro-devel branch get created during after I opened it. |
|
@wjwwood This is what happens when I'm not there to calm your mind with soothing camel sounds... |
severin-lemaignan
referenced
this pull request
in severin-lemaignan/robotpkg
Aug 18, 2014
Changes since 0.1.29: 0.3.0 (2014-06-25) ------------------ * Use system-provided console-bridge * Contributors: Esteve Fernandez 0.2.5 (2014-03-04) ------------------ * Changed format of debug messages so that rosconsole_bridge can correctly parse the prefix * Improved debug output 0.2.4 (2014-02-12) ------------------ * fix race condition with multi threaded library loading (`#16 <https://github.com/ros/class_loader/issues/16>`_) 0.2.3 (2013-08-21) ------------------ * fix missing class name in logWarn output 0.2.2 (2013-07-14) ------------------ * check for CATKIN_ENABLE_TESTING (`#10 <https://github.com/ros/class_loader/issues/10>`_) * fix find Poco to return full lib path (`#8 <https://github.com/ros/class_loader/issues/8>`_) * add missing runtime destination for library under Windows * add Boosst component system 0.2.1 (2013-06-06) ------------------ * improve check for Poco foundation and headers (`#7 <https://github.com/ros/class_loader/issues/7>`_) 0.2.0 (2013-03-13) ------------------ * use find_package for Poco/dl instead to make it work on other platforms * update Poco cmake file to include libdl on non-windows systems * No longer CATKIN_DEPEND on console_bridge Remove useless patches that have been fixed upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OS X, when building dependencies (Poco) into a location which is not on the lib path, I can get this:
It is passing
-LPocoFoundation, to the linker, so in that case you would also need to pass the-L/path/containing/that/lib, OR you can do what this pull request does and just pass the full path to the library, which is better form I think.