noetic release

[ahcorde]

• Python3 changes

• Use setuptools instead of distutils

Since ros/catkin#1048 catkin prefers to use setuptools instead of distutils. The package.xml doesn't need to include python3-setuptools because catkin exports that dependency for the convenience of all downstream python packages.

• Bump CMake version to avoid CMP0048

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

[sloretz]

@ahcorde mind adding a source entry for diagnostics to the Noetic distribution.yaml with test_pull_requests: true? That would allow checking this PR with the ROS 1 build farm

example for a different repo: https://github.com/ros/rosdistro/blob/6dc2f64e9d0242d040a9002f644f352a0a66b19e/noetic/distribution.yaml#L128-L133

[sloretz]

@ros-pull-request-builder retest this please

[ahcorde]

I have some issue with the test called discard_stale_not_published_test:

  File "/home/ahcorde/ros_ws/src/diagnostics/diagnostic_aggregator/test/discard_stale_not_published_test.py", line 99, in test_discard_stale
    self.assert_(len(self._agg_expecteds) == 1

[ahcorde]

@ros-pull-request-builder retest this please

[ahcorde]

thank you for the review @sloretz

[sloretz]

LGTM!

@trainman419 friendly ping :) (or maybe @Karsten1987) mind taking a look and making a ROS Noetic release? This is one of the big repos to get released; it's currently blocking 148 other repos.

[Karsten1987]

I am trusting @sloretz review :)

[Karsten1987]

I assume the travis CI failures can be addressed in a follow up PR