Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic release #71

Merged
merged 7 commits into from May 14, 2020
Merged

Noetic release #71

merged 7 commits into from May 14, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 2, 2020

Following the guidelines to migrate packages to noetic

  • Python3 changes
    • Not really sure about the encode('latin1') and decode('latin1') I waas getting this error:
'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte
  • import setup from setuptools instead of distutils-core

  • Bump CMake version to avoid CMP0048 warning
    This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from sloretz April 2, 2020 14:51
@ahcorde ahcorde changed the base branch from indigo-devel to noetic-devel April 3, 2020 13:44
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 3, 2020

@ros-pull-request-builder retest this please

2 similar comments
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 3, 2020

@ros-pull-request-builder retest this please

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 6, 2020

@ros-pull-request-builder retest this please

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 6, 2020

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass on Focal on my machine

@130s, mind having a look? This is needed for a Noetic release of this repo and metapackages.

In 2c9ebcd and 87c7dd1 I tried updating the travis config to test only the noetic-devel branch, though I'm not familiar enough with ros-industrial/industrial_ci to know if I did the right thing.

@sloretz
Copy link
Contributor

sloretz commented May 14, 2020

@130s since this is needed for metapackages, any objections to me doing the following?

  1. sqaush-merge this PR Noetic release #71
  2. tag version 2.5.0 (Increased minor by 1 for each version since Indigo to leave room for new releases to old distros
  3. Release 2.5.0 with repo status unmaintained

If I don't hear anything in a day I'll assume this is ok; hope you don't mind.

@130s
Copy link
Member

130s commented May 14, 2020

@130s since this is needed for metapackages, any objections to me doing the following?

1. sqaush-merge this PR #71

2. tag version `2.5.0` (Increased minor by 1 for each version since Indigo to leave room for new releases to old distros

3. Release `2.5.0` with repo status `unmaintained`

@sloretz Sure, thank you for taking care of all of these.

And I think CI jobs using industrial_ci failing is expected for now. As filed at ros-industrial/industrial_ci#510, it should become green in June without changing anything on this repo.

@sloretz sloretz merged commit 02bac68 into noetic-devel May 14, 2020
@sloretz sloretz deleted the ahcorde/noetic_release branch May 14, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants