-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noetic release #71
Noetic release #71
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ros-pull-request-builder retest this please |
2 similar comments
@ros-pull-request-builder retest this please |
@ros-pull-request-builder retest this please |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests pass on Focal on my machine
@130s, mind having a look? This is needed for a Noetic
release of this repo and metapackages
.
In 2c9ebcd and 87c7dd1 I tried updating the travis config to test only the noetic-devel
branch, though I'm not familiar enough with ros-industrial/industrial_ci to know if I did the right thing.
@130s since this is needed for
If I don't hear anything in a day I'll assume this is ok; hope you don't mind. |
@sloretz Sure, thank you for taking care of all of these. And I think CI jobs using industrial_ci failing is expected for now. As filed at ros-industrial/industrial_ci#510, it should become green in June without changing anything on this repo. |
Following the guidelines to migrate packages to noetic
encode('latin1')
anddecode('latin1')
I waas getting this error:import setup from setuptools instead of distutils-core
Bump CMake version to avoid CMP0048 warning
This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.