-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf_echo argument inconsistency #111
Comments
Duplicate: #108 |
My bad, only checked the list of open issues. Using "parent_frame" and "child_frame" instead of "source" and "target" might help to alleviate the confusion in the future... |
Closed
This was referenced May 14, 2021
This issue has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/nomenclature-of-tf-echo-and-tf-listener/36985/7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
tf_echo
the source frame and target frame are mixed up, namely, the parent frame is called the "source frame" and the child is the "target", whereas everywhere else in TF and TF2 the convention is the opposite.E.g. here the first argument is called "source_frameid" but it actually is the target frame id.
This inconsistency is really confusing, especially as it's not just the
tf_echo
but also the TF tutorials use the convention opposite from the actual implementation.Should I make a PR for
tf_echo
and fix the tutorials afterwards?The text was updated successfully, but these errors were encountered: