Add conversion functions for Eigen::Isometry3d. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-vri-es
force-pushed
the
indigo-devel
branch
from
382a84a
to
43021c5
Compare
de-vri-es
force-pushed
the
indigo-devel
branch
from
fcd6ec3
to
bea847c
Compare
|
Ping? I'd be interested in this functionality as well. |
|
Thanks this looks good. Especially thanks for including unit tests. |
tfoote
added a commit
that referenced
this pull request
Jan 5, 2016
Add conversion functions for Eigen::Isometry3d.
|
Great. Thanks for the merge. |
|
Thanks. I think #101 can be closed now? |
This was referenced Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added overloads for Eigen::Isometry3d. It makes more sense than Affine3d since tf poses and transforms are isometries, and not affine transformations.
The functions are overloads, so code that is currently working is not affected.
To prevent code duplication the actual conversion is implemented as a function template in an anonymous namespace in the source file.
The unit tests are also updated to check both the affine and isometry versions.