Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial on lookupTwist function #89

Open
wants to merge 19 commits into
base: indigo-devel
Choose a base branch
from

Conversation

rosebudflyaway
Copy link
Member

This is related to issue 43, confirmed from math logic side, the lookupTwist function is correct when calling lookupTransform here.

Connects to #43

@wjwwood
Copy link
Member

wjwwood commented Apr 2, 2015

+1

@rosebudflyaway
Copy link
Member Author

I found the notes on API review of lookupTwist. Questions are below:

transformTwist is commented out, is this function deprecated for tf2?

The member function lookupVelocity of class TransformListener is deprecated?

I suppose this would be replaced by lookupTwist of class Transformer ?

The lookupVelocity function call here are commented and seems to be replaced by the next 3 lines of code?

I guess this test file for transform_twist_test was written some time ago before some functions change API? Is there any suggestion on rewrite a test file or stick with this one (based on the portion of API changes)?

So much fun working on math, I will continue working on this to add a test case and make sure those frame transformation are correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants