Test for equality to None with 'is' instead of '==' #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
requested changes
Jan 22, 2019
There was a problem hiding this comment.
is None is better than == None https://jaredgrubb.blogspot.com/2009/04/python-is-none-vs-none.html
But if we're going to clean this up we don't have a specific meanig for None so generic false check is even cleaner. https://stackoverflow.com/questions/7152441/python-if-not-val-vs-if-val-is-none
Co-Authored-By: daniel-s-ingram <ingramds@appstate.edu>
Co-Authored-By: daniel-s-ingram <ingramds@appstate.edu>
Co-Authored-By: daniel-s-ingram <ingramds@appstate.edu>
Co-Authored-By: daniel-s-ingram <ingramds@appstate.edu>
tfoote
approved these changes
Jan 23, 2019
|
Thanks for the cleanup and iteration! |
seanyen
pushed a commit
to ms-iot/geometry2
that referenced
this pull request
Mar 22, 2021
It has always been disabled in ROS 2. I don't think we have plans at the moment to reenable, so just remove it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.