throttle TF_REPEATED_DATA to 10 seconds #516
Conversation
The TF_REPEATED_DATA error, while important, can be overly verbose, sometimes flooding the terminal scrollback buffer such that no other output can be found. Throttle the error to 10 seconds. Implement the throttling directly since console bridge does not implement throttling. Because ros::Time may not yet be initialized when calling insertData, use the stamp from the message as "now". For more information including the justification for the warning and the justification for a 10 second throttle, read the discussion on issue ros#467: ros#467
|
Please Eris yes. It would be nice to be able to upgrade a system from Melodic to Noetic and see the actual error messages, instead of literally spamming the logfiles into lagging out because someone decided that "works mostly correctly" is equivalent to "fatal error" except without the politeness of actually stopping the erroneous process. |
|
Yes, please, I totally second this. The warning is overly verbose, especially, when simulating. |
| @@ -118,7 +118,7 @@ class TimeCache : public TimeCacheInterface | |||
| L_TransformStorage storage_; | |||
|
|
|||
| ros::Duration max_storage_time_; | |||
|
|
|||
| ros::Time last_repeated_warn_time_; | |||
There was a problem hiding this comment.
This most probably wouldn't make it into Noetic. It changes the ABI of existing code, which would require a total rebuild of the whole Noetic buildfarm.
I suggest moving this completely to the .cpp . You can make this a static variable in the .cpp file, which would preserve ABI. It could also simplify the implementation.
If you no longer feel the urge to get this fix merged, ping @klaxalk , he told he could find some time to dedicate to this fix ;)
|
Alternatively, this problem could be overcome by adding dependency on rosconsole_bridge and putting However, I don't like this alternative too much - it would change the logging behavior someone might be relying on. Also, it would not allow to selectively discard only the TF_REPEATED_DATA messages. |
The TF_REPEATED_DATA error, while important, can be overly verbose,
sometimes flooding the terminal scrollback buffer such that no other
output can be found. Throttle the error to 10 seconds. Implement the
throttling directly since console bridge does not implement throttling.
Because ros::Time may not yet be initialized when calling insertData,
use the stamp from the message as "now".
For more information including the justification for the warning and
the justification for a 10 second throttle, read the discussion on
issue #467:
#467