Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#541 [BUG] child_frame_id not processed #555

Closed
wants to merge 1 commit into from
Closed

#541 [BUG] child_frame_id not processed #555

wants to merge 1 commit into from

Conversation

vineet131
Copy link

No description provided.

tfoote
tfoote reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this in. One review though I think the current behavior is correct. aTb * bTc => aTc. As such only one of the coordinate frame headers should change.

@tfoote tfoote mentioned this pull request Sep 22, 2023
Closed
@vineet131
Copy link
Author

@tfoote got it, thanks! This didn't take much effort, so not a problem. Let me close this then.

@vineet131 vineet131 closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vineet131 @tfoote