Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotransform TransformStamped datatype not process child_frame_id #541

Closed
darkchooselight opened this issue Sep 15, 2022 · 2 comments
Closed
Labels

Comments

@darkchooselight
Copy link

the code do not process child_frame_id transform. look below:
tf2_geometry_msgs/tf2_geometry_msgs.h

template <>
inline
void doTransform(const geometry_msgs::TransformStamped& t_in, geometry_msgs::TransformStamped& t_out, const geometry_msgs::TransformStamped& transform)
  {
    tf2::Transform input;
    fromMsg(t_in.transform, input);

    tf2::Transform t;
    fromMsg(transform.transform, t);
    tf2::Transform v_out = t * input;

    t_out.transform = toMsg(v_out);
    t_out.header.stamp = transform.header.stamp;
    t_out.header.frame_id = transform.header.frame_id;
  }
@tfoote tfoote added the bug label Oct 6, 2022
@tfoote
Copy link
Member

tfoote commented Oct 6, 2022

That does look like it's missing the logic to transfer the child_frame_id if t_in and t_out aren't the same.

vineet131 added a commit to vineet131/ros1-geometry2 that referenced this issue Sep 17, 2023
@tfoote
Copy link
Member

tfoote commented Sep 22, 2023

I was reviewing the PR #555 proposed to resolve this and I think this behavior is actually correct. See my logic there.

@tfoote tfoote closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants