ODR violation fixes and more conversions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Vincent that looks good. I'll process it shortly. |
|
actually, I also need to add a transform for the QuaternionStamped, please hold on. |
|
I did add the types I needed but I'd like another one: being able to convert from geometry_msgs::Pose to tf2::Transform. It is actually done a lot in navigation but semantically, those two are different. Mathematically though, they are (rotation + translation). Can I add it ? (it's useful, otherwise you have to rewrite that conversion method a lot). |
|
Yeah, I'd prefer the distinction but we need to use the same underlying datatype so adding the conversion seems fine. You're right people will do it/want to do it anyway. |
Merged
vrabaud
force-pushed
the
indigo-devel
branch
2 times, most recently
from
7478265
to
7233eff
Compare
|
Hi, this PR is now good to go. Navigation has its tests passing. Thx. |
tfoote
added a commit
that referenced
this pull request
Mar 3, 2015
ODR violation fixes and more conversions
clalancette
pushed a commit
to lucasw/geometry2
that referenced
this pull request
Nov 28, 2018
Fix depend element for eigen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.