Skip to content

[ros2] respect plugin description file subdirectory #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2018
Merged

[ros2] respect plugin description file subdirectory #122

merged 2 commits into from
Jul 18, 2018

Conversation

mikaelarguedas
Copy link
Member

This modifies the macro to install the plugin description file to match the macro docblock:

pluginlib/pluginlib/cmake/pluginlib_export_plugin_description_file.cmake

Lines 36 to 40 in dfa0036

# It's relative path to this file will be preserved when being installed.
# For example, if that argument is "plugins/my_desc.xml", then it will be
# installed to "<prefix>/share/<package>/plugins/my_desc.xml" or if the
# argument is just "my_desc.xml" it would be installed to
# "<prefix>/share/<package>/my_desc.xml".

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987 @wjwwood FYI

@mikaelarguedas mikaelarguedas merged commit c0bbfaf into ros2 Jul 18, 2018
@mikaelarguedas mikaelarguedas deleted the ros2_support_subdirectory branch July 18, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

+1 more reviewer

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelarguedas @wjwwood @Karsten1987