Dynamically choose the appropriate library for experimental filesystem #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the compiler and standard library Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This comment has been minimized.
This comment has been minimized.
|
@nuclearsandwich can we run this one solo? it should be independently correct of the other related PRs |
This comment has been minimized.
This comment has been minimized.
|
I am not able to reproduce these errors, tried on linux and osx with the repos gist from the CI run - and I don't have access to the buildfarm to explore further - any ideas? |
3 tasks
|
The previous CI issue was likely related to misusing colcon package selection for the test phase. Instead of trying to get fancy, I just enumerated packages downstream of pluginlib locally and targetd those:
|
|
I'd like to wait to merge this until we can test that it works with other libcxx changes. |
|
Tested in ros2/poco_vendor#24 (comment). The tests are failing due to undiagnosed issues in class_loader which will be addressed in followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose based on the compiler and standard library
Signed-off-by: Emerson Knapp eknapp@amazon.com
Related to ros2/ros2#664