Skip to content

[ros2] Export tinyxml2 directly from pluginlib-extras.cmake #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented May 8, 2020

When I attempted to build nav2_rviz_plugins, I run into this CMake error:

CMake Error: install(EXPORT "nav2_rviz_plugins" ...) includes target "nav2_rviz_plugins" which requires target "tinyxml2_vendor" that is not in any export set.
CMake Generate step failed.  Build files cannot be regenerated correctly

After some digging, it is coming from this pluginlib-extras.cmake.

  1. I either need to add IMPORTED to make tinyxml2_vendor as an interface imported library,
  2. Or I need to directly define the pluginlib_TARGETS to be tinyxml2 which is the target exported from TinyXML2 project.

@seanyen
Copy link
Contributor Author

seanyen commented May 8, 2020

@dirk-thomas This is ready for review and merge. Thanks.

Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanyen Please don't mention me on all PRs you create. Many repositories have dedicated maintainers which will review incoming tickets.

@seanyen
Copy link
Contributor Author

seanyen commented May 8, 2020

@dirk-thomas Sorry for this one, I was mentioning you because it seems to be broken after this PR #189, so figured you might have better understanding of the issue I run into.

@dirk-thomas
Copy link
Member

dirk-thomas commented May 8, 2020

CI builds with only FastRTPS and no tests:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
    • Unrelated CMake warnings
  • Windows Build Status

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 306f6ca into ros:ros2 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants