do not use popen to solve catkin_path. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the report and the contribution! |
mikaelarguedas
force-pushed
the
bugfix/fix-ENOMEM-popen-error-48
branch
from
e988a86
to
870bd0a
Compare
mikaelarguedas
approved these changes
Jul 26, 2017
There was a problem hiding this comment.
thanks @terakoji for the great improvement! the change looks good to me. We could consider exposing this function through the API (not necessarily in pluginlib) because it can be useful to other packages. But we can do that in the future if it becomes necessary
|
@ros-pull-request-builder retest this please |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #48
Search catkin_path without popen.