Ignore broken curl-config.cmake #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was introduced to maintain existing behavior in CMake 3.17 and newer, where FindCURL.cmake was changed to use curl-config.cmake if it is found. It appears that the curl-config.cmake that comes with the current version of curl that this package includes does not work properly. Until we target a version of curl that has a working curl-config.cmake on Windows, we should continue with the CMake behavior prior to 3.17 by specifying CURL_NO_CURL_CMAKE. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
If that passes CI, I think I prefer this over the alternative. |
jacobperron
approved these changes
Apr 8, 2020
|
CI (build all, test libcurl_vendor resource_retriever)
|
|
@sloretz I would recommend also testing RViz. I think the default plugins make use of the resource retriever. |
CI (test libcurl_vendor resource_retriever, rviz_default_plugins)
|
|
@sloretz - the builds LGTM. Just the one CMake warning on Windows - looks related to spdlog though. |
sloretz
approved these changes
Apr 8, 2020
sloretz
pushed a commit
that referenced
this pull request
Apr 9, 2020
* Ignore broken curl-config.cmake This flag was introduced to maintain existing behavior in CMake 3.17 and newer, where FindCURL.cmake was changed to use curl-config.cmake if it is found. It appears that the curl-config.cmake that comes with the current version of curl that this package includes does not work properly. Until we target a version of curl that has a working curl-config.cmake on Windows, we should continue with the CMake behavior prior to 3.17 by specifying CURL_NO_CURL_CMAKE. Signed-off-by: Scott K Logan <logans@cottsay.net> * Only ignore curl-config.cmake for vendor-built curl Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Apr 9, 2020
* Ignore broken curl-config.cmake This flag was introduced to maintain existing behavior in CMake 3.17 and newer, where FindCURL.cmake was changed to use curl-config.cmake if it is found. It appears that the curl-config.cmake that comes with the current version of curl that this package includes does not work properly. Until we target a version of curl that has a working curl-config.cmake on Windows, we should continue with the CMake behavior prior to 3.17 by specifying CURL_NO_CURL_CMAKE. Signed-off-by: Scott K Logan <logans@cottsay.net> * Only ignore curl-config.cmake for vendor-built curl Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Scott K Logan <logans@cottsay.net>
nuclearsandwich
pushed a commit
that referenced
this pull request
Jun 30, 2020
* Ignore broken curl-config.cmake This flag was introduced to maintain existing behavior in CMake 3.17 and newer, where FindCURL.cmake was changed to use curl-config.cmake if it is found. It appears that the curl-config.cmake that comes with the current version of curl that this package includes does not work properly. Until we target a version of curl that has a working curl-config.cmake on Windows, we should continue with the CMake behavior prior to 3.17 by specifying CURL_NO_CURL_CMAKE. Signed-off-by: Scott K Logan <logans@cottsay.net> * Only ignore curl-config.cmake for vendor-built curl
nuclearsandwich
added a commit
that referenced
this pull request
Jul 1, 2020
* Ignore broken curl-config.cmake This flag was introduced to maintain existing behavior in CMake 3.17 and newer, where FindCURL.cmake was changed to use curl-config.cmake if it is found. It appears that the curl-config.cmake that comes with the current version of curl that this package includes does not work properly. Until we target a version of curl that has a working curl-config.cmake on Windows, we should continue with the CMake behavior prior to 3.17 by specifying CURL_NO_CURL_CMAKE. Signed-off-by: Scott K Logan <logans@cottsay.net> * Only ignore curl-config.cmake for vendor-built curl Co-authored-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was introduced to maintain existing behavior in CMake 3.17 and newer, where FindCURL.cmake was changed to use curl-config.cmake if it is found.
It appears that the curl-config.cmake that comes with the current version of curl that this package includes does not work properly. Until we target a version of curl that has a working curl-config.cmake on Windows, we should continue with the CMake behavior prior to 3.17 by specifying CURL_NO_CURL_CMAKE.
Here is the change in CMake 3.17: Kitware/CMake@c11e7c5
Alternative to #39
Closes #38