[joint_state_publisher] Introduce Gridlayout & tweaking to GUI

[bmagyar]

This should fix the issue of #146. Excuse my sketchy Python :)

As noted above, this is a work in progress PR. Please make comments.

Task list:

• Gridlayout
• CLI param to set maximum number of rows
• Default behaviour replicates existing
• GUI Spinbox to set maximum number of rows, readjust GUI online
• Clean code

[bmagyar]

Any comments @wjwwood ?

[wjwwood]

@bmagyar The code changes look fine to me, but I lack a ready example to "exercise" the feature. What are you using to test it? Is it something I could easily set up and try out?

[bmagyar]

Should this test be part of the PR or is it ok if I put a short list of
commands here?

On 2 Sep 2016 19:06, "William Woodall" notifications@github.com wrote:

@bmagyar https://github.com/bmagyar The code changes look fine to me, but
I lack a ready example to "exercise" the feature. What are you using to
test it? Is it something I could easily set up and try out?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADXH4c_4iWmNAFQIAfCMgHazTV3VsvFOks5qmGWjgaJpZM4Ju-1M
.

[wjwwood]

Just a list of commands. If you think you can automate the test it would be great, but I wasn't suggesting that.

[bmagyar]

I've cleaned up the code a bit, I think now it's worthy for merging.
My test setups is the following:

git clone https://github.com/bmagyar/icub-moveit
cd icub-moveit && git checkout kinetic-devel && cd ..
git clone https://github.com/bmagyar/robot_model
cd robot_model && git checkout kinetic-devel
catkin build

do the usual stuff, then
roslaunch icub_description display.launch
should bring up rviz with the gui.

[wjwwood]

I still want to test this out before merging. I'll try to do that soon.

[bmagyar]

Let me know if you need anything for that. I tested my commands above so it should in theory be fine for you

[VictorLamoine]

👍 VERY useful feature when testing robots with lots of joints and/or a small screen.

I think you should add a label to describe the spinbox at the bottom of the window (something like "Max rows"):

[wjwwood]

Just tested this (sorry for the delay) and it looks good. I'm going to merge this, but I agree with @VictorLamoine that a label on the spinbox would be really great. If anyone has time to add that, please open a new pr, I'll be sure to merge it fast.

[wjwwood]

Thanks again @bmagyar!