This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
Fix rostest dependency. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepurvis
commented
Mar 20, 2017
| @@ -9,7 +9,7 @@ install(PROGRAMS joint_state_publisher/joint_state_publisher DESTINATION ${CATKI | |||
|
|
|||
|
|
|||
| if(CATKIN_ENABLE_TESTING) | |||
| find_package(catkin REQUIRED COMPONENTS rostest) | |||
| find_package(rostest) | |||
There was a problem hiding this comment.
You shouldn't re-find catkin. Just find the additional package you need separately.
mikepurvis
commented
Mar 20, 2017
| @@ -13,12 +13,9 @@ | |||
|
|
|||
| <buildtool_depend>catkin</buildtool_depend> | |||
|
|
|||
| <build_depend>rospy</build_depend> | |||
| <build_depend>python_qt_binding</build_depend> | |||
| <build_depend>sensor_msgs</build_depend> | |||
There was a problem hiding this comment.
No need to build-depend on these; they aren't used at build time.
|
This looks OK to me (and makes the package more similar to other ones I've looked at), so I'm going to merge it. I still don't completely understand the situation that this causes problems in, so some feedback on how exactly the previous code causes problems would just help me understand better. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue reported in #190, introduced in #177.
FYI @tspicer01 @alextoind @sloretz