Use urdf::*ShredPtr instead of boost::shared_ptr #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspricke
force-pushed
the
urdfdom_headers_fix
branch
from
b00d94c
to
2bed543
Compare
urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use them to stay compatible. This also adds a proper dependency for urdfdom-headers
jspricke
force-pushed
the
urdfdom_headers_fix
branch
from
2bed543
to
91c166f
Compare
|
I believe this would break Wily and Jessie, as it did for other repositories. I think it will need to use the compatibility header from |
|
@wjwwood ping. |
|
I still haven't tested this on Wily or Jessie, but I think edaf038 was meant to address this. I'll do a release and see what happens based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom
*SharedPtr type, we can use the to sty compatible.
This also adds a proper dependency for urdfdom-headers