Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on tf and tf_prefix support #82

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Remove dependency on tf and tf_prefix support #82

merged 1 commit into from
Feb 14, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 13, 2018

This PR removes the dependency on tf (#79) and the long deprecated tf_prefix. I have not done a prerelease test yet. It is likely the removal of the tf_prefix argument will break downstream users of the c++ API.

@sloretz sloretz self-assigned this Feb 13, 2018
clalancette
clalancette approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks OK to me. Please do a prerelease on the downstream users and open up PRs for the broken ones before merging, though.

This was referenced Feb 14, 2018
Merged
Closed
@sloretz
Copy link
Contributor Author

sloretz commented Feb 14, 2018

Looks like a --level 2 prerelease test successfully builds with just the 2 referenced PRs. There were a few packages whose apt dependencies couldn't be installed: magni_demos, magni_robot, minas, tra1_bringup, tra1_description, tra1_moveit_config. However, all of these run_depend or exec_depend on this package so I don't expect them to be affected. I think it is safe to merge this.

@sloretz sloretz merged commit b611b86 into melodic-devel Feb 14, 2018
@sloretz sloretz deleted the remove_tf_dependency branch February 14, 2018 21:35
@sloretz sloretz mentioned this pull request Feb 14, 2018
Closed
@sloretz sloretz mentioned this pull request Feb 27, 2018
Merged
@clalancette clalancette mentioned this pull request Mar 22, 2019
Closed
@sloretz sloretz mentioned this pull request Aug 14, 2019
Closed
clalancette added a commit that referenced this pull request Aug 27, 2019
@clalancette
Revert "Remove dependency on tf and tf_prefix support (#82)"
3e55c9e 
This reverts commit b611b86.
clalancette added a commit that referenced this pull request Aug 27, 2019
@clalancette
Revert "Remove dependency on tf and tf_prefix support (#82)" (#113)
55203e5 
This reverts commit b611b86.
rhaschke added a commit to rhaschke/robot_state_publisher that referenced this pull request May 26, 2020
@rhaschke
Restore tf_prefix support
c4f41fb 
This partially reverts ros#82, commit b611b86.
@rhaschke rhaschke mentioned this pull request May 26, 2020
Closed
@mabelzhang mabelzhang mentioned this pull request May 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@sloretz sloretz

Labels
Melodic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette