Make RospyLogger.findCaller compatible with Python3 (also, unbreak ROS on Python3) #1121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the change in #1043, ROS was broken on Python3. The findCaller function in Python3 logging module takes 2 arguments (including self) compared to only 1 (self) in Python2 and returns 4 values instead of 3 in Python2.
Without this patch, roscore doesn't even start: