Coverity - invalidate iterator cause overflow

[danielwangksu]

It seems to me ROS_ASSERT_MSG only works when ROS_ASSERT_ENABLED is defined.
This leads to a problem in the remove() function in clients/roscpp/src/libros/spinner.cpp.
When ROS_ASSERT_ENABLED is not defined, the iterator loop will run out
of the scope of the array, and cause overflow.

ros_comm/clients/roscpp/src/libros/spinner.cpp

Lines 94 to 97 in 29053c4

	std::map<ros::CallbackQueue*, Entry>::iterator it = spinning_queues_.find(queue);
	ROS_ASSERT_MSG(it != spinning_queues_.end(), "Call to SpinnerMonitor::remove() without matching call to add().");
	if (it->second.tid != boost::thread::id() && it->second.tid != boost::this_thread::get_id())

[dirk-thomas]

Please consider to provide a pull request for this.

[danielwangksu]

I think this should be a false alarm.